v3.2: Strengthen generic data types to a SHOULD #4657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added as a MAY in 3.1.1 but we can make it a SHOULD in 3.2.
ralfhandl
approved these changes
Jun 6, 2025
karenetheridge
approved these changes
Jun 8, 2025
This was referenced Jun 11, 2025
miqui
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I had already done this one-word change but I guess I forgot!
This was added as a MAY in 3.1.1 but we can make it a SHOULD in 3.2.
I'd love to make it a MUST but there might be scenarios where it is not feasible, or where alternate interpretations are valid. For example, the OAS schema and the JSON Schema metaschema use
$dynamicRef, but to support a recursive data structure rather than a generic one.This is the minimum change to more strongly encourage support for this much-demanded feature (it closed 5 separate issues when we added it) that currently is one of the least-supported JSON Schema keywords despite high demand.